SWIFT-1308 Run initial DNS seedlist discovery load balancer tests #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Sep 1, 2021
| case (.loadBalanced, false): | ||
| guard let uri = Self.multipleMongosLoadBalancedURI else { | ||
| fatalError("Missing MULTIPLE_MONGOS_LB_URI environment variable") | ||
| fatalError("Missing MULTI_MONGOS_LB_URI environment variable") |
Contributor
Author
There was a problem hiding this comment.
forgot to update this in previous PR changing the env var name
| asType: DNSSeedlistTestCase.self | ||
| ) | ||
| for (fileName, testCase) in tests { | ||
| // TODO: SWIFT-910: unskip this test |
Contributor
Author
There was a problem hiding this comment.
CDRIVER released their work for this ticket in 1.19 so we can close out ours now as well
patrickfreed
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the existing tests into the
replica-setdirectory, syncs the tests, and updates the runner to run the new tests when connected to a load balancer.patch